Free the raw device when wgpu::Device is dropped.
#2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a "see if this works" patch; totally open to suggestions for different approaches. |
Go ahead and call `global.device_drop` from `direct::Context::device_drop`. Let `Global::device_drop` simply drop the life guard's `RefCount`, and put off everything else entailed in freeing a device until `Device::maintain` says its queue is empty and there are no more references to it. (The user can reach that function, even after dropping their `Device`, by calling `wgpu::Instance::poll_all`.) Fixes gfx-rs#2563.
kvark
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go ahead and call
global.device_dropfromdirect::Context::device_drop.Let
Global::device_dropsimply drop the life guard'sRefCount, and put off everything else entailed in freeing a device untilDevice::maintainsays its queue is empty and there are no more references to it. (The user can reach that function, even after dropping theirDevice, by callingwgpu::Instance::poll_all.)Fixes #2563.
This won't have any effect until #2565 is landed as well.